Re: Verbosity of genbki.pl

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, John Naylor <jcnaylor@gmail.com>
Date: 2018-04-28T15:34:36Z
Lists: pgsql-hackers
On 4/9/18 15:02, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2018-04-08 13:33:42 -0400, Tom Lane wrote:
>>> Traditionally genbki.pl has printed "Writing foo" for every file
>>> it writes out.
> 
>>> 2. Print just one message like "Generating postgres.bki and related
>>> files", and I guess a second one for fmgroids.h and related files.
> 
>> +0.5.
> 
> Hearing no votes against, done that way.

Maybe we can take another look at this.  Right now, make -s world
produces *only* the following output:

$ make -s world
Generating BKI files and symbol definition headers...
Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...
PostgreSQL, contrib, and documentation successfully made. Ready to install.

That seems kind of inconsistent and silly.  I suggest we remove the
output from these scripts.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Commits

  1. Remove "Generating" output from catalog scripts

  2. Reduce chattiness of genbki.pl and Gen_fmgrtab.pl.