Horton

Re: pg_upgrade --copy-file-range

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-12-22T20:40:48Z
Lists: pgsql-hackers 
On 13.11.23 08:15, Peter Eisentraut wrote:
> On 08.10.23 07:15, Thomas Munro wrote:
>>> About your patch:
>>>
>>> I think you should have a "check" function called from
>>> check_new_cluster().  That check function can then also handle the "not
>>> supported" case, and you don't need to handle that in
>>> parseCommandLine().  I suggest following the clone example for these,
>>> since the issues there are very similar.
>>
>> Done.
> 
> This version looks good to me.
> 
> Tiny nit:  You copy-and-pasted "%s/PG_VERSION.clonetest"; maybe choose a 
> different suffix.

Thomas, are you planning to proceed with this patch?

Commits

  1. Allow using copy_file_range in write_reconstructed_file

  2. Allow copying files using clone/copy_file_range

  3. Align blocks in incremental backups to BLCKSZ

  4. Add --copy-file-range option to pg_upgrade.