Horton

Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.

Gilles DAROLD <gilles@darold.net>

View thread View on postgr.es
From: Gilles Darold <gilles@darold.net>
To: Michael Paquier <michael@paquier.xyz>, Etsuro Fujita <etsuro.fujita@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-08T09:19:01Z
Lists: pgsql-hackers 
Hi Michael,


Le 08/11/2019 à 10:05, Michael Paquier a écrit :
> On Fri, Nov 08, 2019 at 05:25:52PM +0900, Etsuro Fujita wrote:
>> Pushed after modifying the commit message a bit.  Thanks!
> Should we have more tests for 2PC then?
> --
> Michael


I don't think so. The support or not of 2PC is on foreign data wrapper
side. In postgres_fdw contrib the error for use with 2PC is not part of
the test but it will be thrown anyway. I guess that a test will be
valuable only if there is support for readonly query.


-- 
Gilles Darold

Commits

  1. Add regression test for two-phase transaction in postgres_fdw

  2. postgres_fdw: Fix error message for PREPARE TRANSACTION.