Re: Extra Vietnamese unaccent rules
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Dang Minh Huong <kakalot49@gmail.com>, Bruce Momjian <bruce@momjian.us>,
Thomas Munro <thomas.munro@enterprisedb.com>,
Kha Nguyen <nlhkha@gmail.com>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-08-17T02:56:47Z
Lists: pgsql-hackers
Michael Paquier <michael.paquier@gmail.com> writes: > On Thu, Aug 17, 2017 at 6:01 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I'm not really qualified to review the Python coding >> style, but I did fix a typo in a comment. > No pythonist here, but a large confusing "if" condition without any > comments is better if split up and explained with comments if that can > help in clarifying what the code is doing in any language, so thanks > for keeping the code intact. Certainly agreed on splitting up the logic into multiple statements. I just meant that I don't know enough Python to know if there are better ways to do these tests. (It probably doesn't matter, since performance of this script is not an issue, and it's not likely to undergo a lot of further development either.) regards, tom lane
Commits
-
Extend the default rules file for contrib/unaccent with Vietnamese letters.
- ec0a69e49bf4 11.0 landed