Horton

RE: A new function to wait for the backend exit after termination

Hou, Zhijie <houzj.fnst@cn.fujitsu.com>

View thread View on postgr.es
From: "Hou, Zhijie" <houzj.fnst@cn.fujitsu.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Muhammad Usama <m.usama@gmail.com>
Date: 2020-12-03T02:21:51Z
Lists: pgsql-hackers 
> > +	ereport(WARNING,
> > +			(errmsg("could not wait for the termination of the
> backend with PID %d within %ld milliseconds",
> > +					pid, timeout)));
> 
> > The code use %ld to print int64 type.
> > How about use INT64_FORMAT, which looks more appropriate.
> 
> This is a translatable message, so INT64_FORMAT is no good -- we need
> something that is the same across platforms.  The current project standard
> for this problem is to use "%lld" and explicitly cast the argument to long
> long int to match that.

Thank you for pointing out that,
And sorry for did not think of it.

Yes, we can use %lld, (long long int) timeout.

Best regards,
houzj

Commits

  1. Copy-edit text for the pg_terminate_backend() "timeout" parameter.

  2. Remove pg_wait_for_backend_termination().

  3. Add functions to wait for backend termination

  4. Fix typo in comment.