Re: pgsql: Remove inappropriate memory context switch in

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Neil Conway" <neilc@samurai.com>
Cc: pgsql-committers@postgresql.org
Date: 2008-11-30T21:09:18Z
Lists: pgsql-hackers
"Neil Conway" <neilc@samurai.com> writes:
> On Sun, Nov 30, 2008 at 10:49 AM, Tom Lane <tgl@postgresql.org> wrote:
>> Remove inappropriate memory context switch in shutdown_MultiFuncCall().

> I added that context switch for a reason:
> http://archives.postgresql.org/pgsql-patches/2008-02/msg00153.php

Hm, too bad you didn't respond to my message inquiring about this a
couple days ago.

> Presumably that's why the build farm is crashing on dblink.

I'll take a look in a bit.  However, the switch in the shutdown function
was simply wrong, because it was *not* "returning to the caller's
context".  I suspect what this really says is dblink is doing something
it shouldn't.

			regards, tom lane