Re: automating RangeTblEntry node support

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-01-15T10:37:15Z

Lists: pgsql-hackers

Attachments

v2-0001-Remove-custom-Constraint-node-read-write-implemen.patch (text/plain) patch v2-0001
v2-0002-Remove-custom-_jumbleRangeTblEntry.patch (text/plain) patch v2-0002
v2-0003-Simplify-range_table_mutator_impl.patch (text/plain) patch v2-0003
v2-0004-WIP-Remove-custom-RangeTblEntry-node-read-write-i.patch (text/plain) patch v2-0004

On 06.12.23 21:02, Peter Eisentraut wrote:
> I have been looking into what it would take to get rid of the 
> custom_read_write and custom_query_jumble for the RangeTblEntry node 
> type.  This is one of the larger and more complex exceptions left.
> 
> (Similar considerations would also apply to the Constraint node type.)

In this updated patch set, I have also added the treatment of the 
Constraint type.  (I also noted that the manual read/write functions for 
the Constraint type are out-of-sync again, so simplifying this would be 
really helpful.)  I have also added commit messages to each patch.

The way I have re-ordered the patch series now, I think patches 0001 
through 0003 are candidates for inclusion after review, patch 0004 still 
needs a bit more analysis and testing, as described therein.

Commits

Make RangeTblEntry dump order consistent
- b4080fa3dcf6 17.0 landed
Remove custom _jumbleRangeTblEntry()
- 367c989cd840 17.0 landed
Reformat some node comments
- d575051b9af9 17.0 landed
Improve comment
- 1e1eb12c25c3 17.0 landed
Remove obsolete comment
- 83d8065b1f74 17.0 landed
Remove custom Constraint node read/write implementations
- fbc93b8b5f59 17.0 landed