Re: Using defines for protocol characters

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Cramer <davecramer@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Smith <smithpb2250@gmail.com>, Tatsuo Ishii <ishii@sraoss.co.jp>, pgsql-hackers@lists.postgresql.org, nathandbossart@gmail.com
Date: 2023-08-07T20:02:08Z
Lists: pgsql-hackers
Dave Cramer <davecramer@gmail.com> writes:
> On Mon, 7 Aug 2023 at 12:59, Robert Haas <robertmhaas@gmail.com> wrote:
>> PqMsgEmptyQueryResponse or something like that seems better, if we
>> want to keep the current capitalization. I'm not a huge fan of the way
>> we vary our capitalization conventions so much all over the code base,
>> but I think we would at least do well to keep it consistent from one
>> end of a certain identifier to the other.

> I don't have a strong preference, but before I make the changes I'd like to
> get consensus.
> Can we vote or whatever it takes to decide on a naming pattern that is
> acceptable ?

I'm good with Robert's proposal above.

			regards, tom lane



Commits

  1. Introduce macros for protocol characters.

  2. Remove configure check for z_streamp