Re: Fix volatile vs. pointer confusion
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-14T07:48:09Z
Lists: pgsql-hackers
On 2019-03-11 08:23, Peter Eisentraut wrote: > Variables used after a longjmp() need to be declared volatile. In > case of a pointer, it's the pointer itself that needs to be declared > volatile, not the pointed-to value. So we need > > PyObject *volatile items; > > instead of > > volatile PyObject *items; /* wrong */ > > Attached patch fixes a couple of cases of that. Most instances were > already correct. Committed. I'll wait for the build farm to see if there are any new compiler warnings because of this, then backpatch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix volatile vs. pointer confusion
- 361cabb11d36 9.5.17 landed
- 626c8ed2ef6d 9.6.13 landed
- c77f21899ac2 10.8 landed
- a1e9508b9641 11.3 landed
- 1226d932b4da 12.0 landed