Re: More business with $Test::Builder::Level in the TAP tests
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-10-08T08:06:04Z
Lists: pgsql-hackers
> On 8 Oct 2021, at 09:51, Michael Paquier <michael@paquier.xyz> wrote: > > On Fri, Oct 08, 2021 at 09:28:04AM +0200, Daniel Gustafsson wrote: >> LGTM. Maybe it should be added that it *must* be called before any Test::More >> function is called, it's sort of self-explanatory but not everyone writing TAP >> tests will be deeply familiar with Perl. > > I think that "must" is too strong in this context, as in some cases it > does not really make sense to increment the level, when using for > example a rather long routine that's labelled with one of the > routine arguments like for pg_rewind. So I would stick with > "should". Fair enough. -- Daniel Gustafsson https://vmware.com/
Commits
-
Add more $Test::Builder::Level in the TAP tests
- d5ab331a339d 12.9 landed
- bab0ff2e44b7 13.5 landed
- d834ebcf2320 14.1 landed
- f9c4cb686800 15.0 landed
-
Add missing $Test::Builder::Level settings
- 73aa5e0cafd0 15.0 cited