Re: Minimal logical decoding on standbys

bdrouvotAWS <bdrouvot@amazon.com>

From: "Drouvot, Bertrand" <bdrouvot@amazon.com>

To: <fabriziomello@gmail.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, tushar <tushar.ahuja@enterprisedb.com>, "[pgdg] Robert Haas" <robertmhaas@gmail.com>, Amit Khandekar <amitdkhan.pg@gmail.com>, Rahila Syed <rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2021-03-24T06:56:51Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Reduce the log level in 035_standby_logical_decoding.pl.
- 3034dc56ef4b 16.0 landed
035_standby_logical_decoding: Add missing waits for replication
- 57411c82ce86 16.0 landed
For cascading replication, wake physical and logical walsenders separately
- e101dfac3a53 16.0 landed
Handle logical slot conflicts on standby
- 26669757b6a7 16.0 landed
Support invalidating replication slots due to horizon and wal_level
- be87200efd93 16.0 landed
Prevent use of invalidated logical slot in CreateDecodingContext()
- 4397abd0a2af 16.0 landed
Replace replication slot's invalidated_at LSN with an enum
- 15f8203a5975 16.0 landed
Pass down table relation into more index relation functions
- 61b313e47eb9 16.0 landed
Assert only valid flag bits are passed to visibilitymap_set()
- a88a18b1250b 16.0 landed
Remove unused _bt_delitems_delete() argument.
- dc43492e46c7 14.0 cited
Add xl_btree_delete optimization.
- d2e5e20e5711 13.0 cited

Attachments

v14-0005-Doc-changes-describing-details-about-logical-dec.patch (text/plain) patch v14-0005
v14-0004-New-TAP-test-for-logical-decoding-on-standby.patch (text/plain) patch v14-0004
v14-0003-Handle-logical-slot-conflicts-on-standby.patch (text/plain) patch v14-0003
v14-0002-Add-info-in-WAL-records-in-preparation-for-logic.patch (text/plain) patch v14-0002
v14-0001-Allow-logical-decoding-on-standby.patch (text/plain) patch v14-0001

On 3/23/21 11:05 PM, Fabrízio de Royes Mello wrote:
>
> >
> > done in v13 attached.
> >
>
> All tests passed and everything looks good to me... just a final 
> minor fix on regression tests:
>
> diff --git a/src/test/regress/expected/rules.out 
> b/src/test/regress/expected/rules.out
> index b0e17d4e1d..961ec869a6 100644
> --- a/src/test/regress/expected/rules.out
> +++ b/src/test/regress/expected/rules.out
> @@ -1869,9 +1869,9 @@ pg_stat_database_conflicts| SELECT d.oid AS datid,
>      pg_stat_get_db_conflict_tablespace(d.oid) AS confl_tablespace,
>      pg_stat_get_db_conflict_lock(d.oid) AS confl_lock,
>      pg_stat_get_db_conflict_snapshot(d.oid) AS confl_snapshot,
> -    pg_stat_get_db_conflict_logicalslot(d.oid) AS confl_logicalslot,
>      pg_stat_get_db_conflict_bufferpin(d.oid) AS confl_bufferpin,
> -    pg_stat_get_db_conflict_startup_deadlock(d.oid) AS confl_deadlock
> +    pg_stat_get_db_conflict_startup_deadlock(d.oid) AS confl_deadlock,
> +    pg_stat_get_db_conflict_logicalslot(d.oid) AS confl_logicalslot
>     FROM pg_database d;
>  pg_stat_gssapi| SELECT s.pid,
>      s.gss_auth AS gss_authenticated,
>
> We moved "pg_stat_database_conflicts.confl_logicalslot" to the end of 
> the column list but forgot to change the regression test expected result.

Thanks for pointing out, fixed in v14 attached.

Bertrand