Re: 4 pgcrypto regressions failures - 1 unsolved
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marko Kreen <marko@l-t.ee>
Cc: Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org
Date: 2005-07-11T14:39:26Z
Lists: pgsql-hackers
Marko Kreen <marko@l-t.ee> writes: > On Mon, Jul 11, 2005 at 10:10:12AM -0400, Tom Lane wrote: >> The following addition to the patch shuts up gcc with openssl 0.9.7a, >> but I'm not sure if it will break anything with older openssl --- >> comments? > They won't matter on older OpenSSL, as the macros will recast > again. But on 0.9.7e the signature is: > void DES_ecb3_encrypt(const unsigned char *input, unsigned char *output, > DES_key_schedule *ks1,DES_key_schedule *ks2, > DES_key_schedule *ks3, int enc); > so it seems to me that with your patch the warnings will appear > on newer OpenSSL. (Confirmed) Grumble --- you're right. It's probably not worth ifdef'ing the code to suppress the warnings on 0.9.7a ... regards, tom lane