Horton

Re: BUG #17777: An assert failed in nodeWindowAgg.c

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, xinwen@stu.scu.edu.cn, pgsql-bugs@lists.postgresql.org
Date: 2023-02-12T16:19:41Z
Lists: pgsql-bugs 
David Rowley <dgrowleyml@gmail.com> writes:
> On Sat, 11 Feb 2023 at 13:49, Andres Freund <andres@anarazel.de> wrote:
>> I think we could just add a !contain_subplans() to the code deciding whether
>> it's safe to use the movable window optimization?

> I think this is a fair way to fix the bug.

Agreed.

> Here's a patch for that.

Why is it okay to check only the filter, and not the rest of the
WindowFunc's subexpressions?  The arguments we've just run through
seem to apply to a subplan in the direct or aggregated arguments
as well.

			regards, tom lane

Commits

  1. Disable WindowAgg inverse transitions when subplans are present