Re: pg_upgrade failing for 200+ million Large Objects

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: vignesh C <vignesh21@gmail.com>

Cc: "Kumar, Sachin" <ssetiya@amazon.com>, Robins Tharakan <tharakan@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, Jan Wieck <jan@wi3ck.info>, Bruce Momjian <bruce@momjian.us>, Zhihong Yu <zyu@yugabyte.com>, Andrew Dunstan <andrew@dunslane.net>, Magnus Hagander <magnus@hagander.net>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2024-01-26T16:44:26Z

Lists: pgsql-hackers

Attachments

v10-0001-Some-small-preliminaries-for-pg_dump-changes.patch (text/x-diff) patch v10-0001
v10-0002-In-dumps-group-large-objects-into-matching-metad.patch (text/x-diff) patch v10-0002
v10-0003-Move-BLOBS-METADATA-TOC-entries-into-SECTION_DAT.patch (text/x-diff) patch v10-0003
v10-0004-Invent-transaction-size-option-for-pg_restore.patch (text/x-diff) patch v10-0004

vignesh C <vignesh21@gmail.com> writes:
> CFBot shows that the patch does not apply anymore as in [1]:
> === Applying patches on top of PostgreSQL commit ID
> 46a0cd4cefb4d9b462d8cc4df5e7ecdd190bea92 ===
> === applying patch ./v9-005-parallel_pg_restore.patch
> patching file src/bin/pg_upgrade/pg_upgrade.c
> Hunk #3 FAILED at 650.
> 1 out of 3 hunks FAILED -- saving rejects to file
> src/bin/pg_upgrade/pg_upgrade.c.rej

That's because v9-005 was posted by itself.  But I don't think
we should use it anyway.

Here's 0001-0004 again, updated to current HEAD (only line numbers
changed) and with Nathan's suggestion to define some macros for
the magic constants.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Count individual SQL commands in pg_restore's --transaction-size mode.
- 81db073a2878 17.0 landed
- 0f1290521504 18.0 landed
Reduce number of commands dumpTableSchema emits for binary upgrade.
- b3f0e0503f33 18.0 landed
- 2fa989e6a340 17.0 landed
Invent --transaction-size option for pg_restore.
- 959b38d770ba 17.0 landed
Rearrange pg_dump's handling of large objects for better efficiency.
- a45c78e3284b 17.0 landed
Add temporal PRIMARY KEY and UNIQUE constraints
- 46a0cd4cefb4 17.0 cited
Fix typo and case in messages
- 7d7ef075d2b3 17.0 cited