Re: cleaning perl code

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-04-11T08:06:51Z
Lists: pgsql-hackers
On 2020-04-11 06:30, Noah Misch wrote:
> In summary, among those warnings, I see non-negative value in "Code before
> warnings are enabled" only.

Now that you put it like this, that was also my impression when I first 
introduced the level 5 warnings and then decided to stop there.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Stop requiring an explicit return from perl subroutines

  2. Use perl's $/ more idiomatically

  3. Use perl warnings pragma consistently