Re: Add support for logging the current role

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Itagaki Takahiro <itagaki.takahiro@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-02-17T16:10:35Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add support for an application_name parameter, which is displayed in

  2. Make CSV column ordering a bit more logical.

  3. Extend the format of CSV logs to include the additional information supplied

  4. Add virtual transaction IDs to CSVLOG output, so that messages coming from

  5. Provide for logfiles in machine readable CSV format. In consequence, rename

Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> Yeah, I thought what was supposed to be emitted was the value of
>> current_user, not SQL's weird definition of what SET ROLE means.

> current_user uses GetUserNameFromId() and goes through the cache lookups
> to get there.  I was using what show_role() returns (which is also what
> 'show role;' returns).  I'd be happy to make it emit an empty string
> when 'none' is returned though.

Well, that just doesn't seem useful to me in the real world.  If I were
using this, I would expect it to emit a real user name that matches the
currently applied permissions checking.  All the time.  "show role" does
what it does because the SQL standard says so, not because anybody
outside the standards committee thinks that's a sane definition.

			regards, tom lane