Re: Inconsistencies around defining FRONTEND
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
Noah Misch <noah@leadboat.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
samay sharma <smilingsamay@gmail.com>,
Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: 2022-08-23T23:50:00Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Tue, Aug 23, 2022 at 7:24 PM Andres Freund <andres@anarazel.de> wrote: >> Just to make sure I understand - you're just trying to get rid of the #define >> frontends, not the -DFRONTENDs passed in from the Makefile? Because afaics we >> still need those, correct? > Oh, yeah, this only fixes the #define ones. But maybe fixing the other > ones with a similar approach would be possible? > I really don't see why we should tolerate having #define FRONTEND in > more than once place. src/port and src/common really need to do it like that (ie pass in the -D switch) so that the identical source file can be built both ways. Maybe we could get rid of -DFRONTEND in other places, like pg_rewind and pg_waldump. regards, tom lane
Commits
-
Don't define FRONTEND for ecpg libraries
- 9352d5cf128a 16.0 landed
-
Don't define FRONTEND for initdb
- 06e3559bade1 16.0 landed
-
Don't define FRONTEND for libpq
- 1d77afefbd1d 16.0 landed