Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch

Bernd Helmle <mailings@oopsware.de>

From: Bernd Helmle <mailings@oopsware.de>

To: Dean Rasheed <dean.a.rasheed@gmail.com>, Alvaro Herrera <alvherre@commandprompt.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Andrew Geery <andrew.geery@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2010-10-15T07:32:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Catalog NOT NULL constraints
- e056c557aef4 16.0 landed

--On 14. Oktober 2010 20:47:27 +0100 Dean Rasheed 
<dean.a.rasheed@gmail.com> wrote:

> OK, here it is.
>
> I've not cured this compiler warning (in fact I'm not sure what it's
> complaining about, because the variable *is* used):
>
> tablecmds.c: In function 'ATExecSetNotNull':
> tablecmds.c:4747: warning: unused variable 'is_new_constraint'

Just a left over from earlier coding, i have removed this in my patch 
version. I have adapted your fixes and would like to propose that we are 
proceeding with my version, if that's okay for you?

-- 
Thanks

	Bernd