Re: review: psql: edit function, show function commands patch
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Jan Urbański <wulczer@wulczer.org>, Postgres - Hackers <pgsql-hackers@postgresql.org>
Date: 2010-08-12T00:43:20Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > I suggest that we punt the \sf portion of this patch back for rework for > the next CommitFest, and focus on getting the \e and \ef changes > committed. I think the \sf code can be a lot simpler if we get rid of > the code that's intended to recognize the ending delimeter. I've committed the \e/\ef part after some further tweaking. I concur with marking the \sf part as Returned With Feedback. > Another thought is that we might want to add a comment to > pg_get_functiondef() noting that anyone changing the output format > should be careful not to break the line-number-finding form of \ef in > the process. Done. regards, tom lane