Horton

Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )

Ian Barwick <ian.barwick@2ndquadrant.com>

View thread View on postgr.es
From: Ian Barwick <ian.barwick@2ndquadrant.com>
To: Sergei Kornilov <sk@zsrv.org>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2019-07-19T13:40:42Z
Lists: pgsql-hackers 
On 7/19/19 7:45 PM, Sergei Kornilov wrote:
> Hi
> 
> Oh. Replication slot name currently can contains only a-z0-9_ characters. So
> we can not actually write such recovery.conf, pg_basebackup will stop
> before. But perform escape_quotes on string and not use result - error anyway.

Good point, it does actually fail with an error if an impossible slot name
is provided, so the escaping is superfluous anyway.

I'll take another look at it later as it's not exactly critical, just stuck
out when I was passing through the code.


Regards

Ian Barwick


-- 
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Don't uselessly escape a string that doesn't need escaping

  2. pg_basebackup: Add --slot option