doc: some fixes for environment sections in ref pages

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-05-13T08:48:53Z
Lists: pgsql-hackers

Attachments

I noticed that the reference pages for initdb and pg_ctl claim in the 
Environment section that libpq variables are used, which does not seem 
correct to me.  I think this was accidentally copied when this blurb was 
added to other pages.

While I was checking around that, I also noticed that pg_amcheck and 
pg_upgrade don't have Environment sections on their reference pages, so 
I added them.  For pg_amcheck I copied the standard text for client 
programs.  pg_upgrade has its own specific list of environment variables.

Patches attached.  I think the first one is a bug fix.

Commits

  1. doc: Remove claims that initdb and pg_ctl use libpq environment variables

  2. doc: Add standard Environment section to pg_amcheck ref page

  3. doc: Add standard Environment section to pg_upgrade ref page