Horton

Re: Modernizing SQL functions' result type coercions

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org, Petr Fedorov <petr.fedorov@phystech.edu>
Date: 2020-01-08T15:22:55Z
Lists: pgsql-hackers 
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> In init_sql_fcache(), one comment says that the junkfilter is 
> responsible for injecting NULLs for dropped columns, and a later comment 
> says that the junk filter gets "rid of any dropped columns". That seems 
> contradictory; which is it? Or does "get rid of" mean "set to NULL"?

Yeah, the second comment is sloppily worded; the first one is more
accurate.

> Other than that, looks good to me.

Thanks for reviewing!  I'll fix that comment and push.

			regards, tom lane

Commits

  1. Improve the handling of result type coercions in SQL functions.