Horton

Re: Fixing MSVC's inability to detect elog(ERROR) does not return

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-30T19:32:09Z
Lists: pgsql-hackers 
On 30.09.25 11:03, David Rowley wrote:
> On Tue, 30 Sept 2025 at 18:24, Peter Eisentraut <peter@eisentraut.org> wrote:
>> Quick follow-up: How about we rename pg_builtin_integer_constant_p to
>> pg_integer_constant_p, since it's not actually built-in?  See attached
>> patch.
> 
> Seems like a good idea.
> 
> The patch looks good. Thanks for fixing the __builtin_const_p typo
> that I managed to introduce too :|

pushed

Commits

  1. Rename pg_builtin_integer_constant_p to pg_integer_constant_p

  2. Teach MSVC that elog/ereport ERROR doesn't return