Re: Adding support for SSLKEYLOGFILE in the frontend
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
Tom Lane <tgl@sss.pgh.pa.us>,
Abhishek Chanda <abhishek.becs@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-18T12:42:44Z
Lists: pgsql-hackers
> On 17 Mar 2025, at 16:48, Jacob Champion <jacob.champion@enterprisedb.com> wrote: > > On Sun, Mar 16, 2025 at 6:49 AM Daniel Gustafsson <daniel@yesql.se> wrote: >> IIRC the reasoning has been that if a rogue user can inject an environment >> variable into your session and read your files it's probably game over anyways. > > (Personally I'm no longer as convinced by this line of argument as I > once was...) Since there is disagreement over this, we should either 1) go ahead with the latest patch without an env var and revisit the discussion during v19; 2) adding the env var back into the patch as PGSSLKEYLOGFILE or; 3) postponing all of this till v19? Personally I think this feature has enough value even without the env var to not postpone it, especially since adding an env var in 19 will still be backwards compatible. I would go for option 1 to stay on the safe side and allow time for proper discussion, any other thoughts? -- Daniel Gustafsson
Commits
-
Fix sslkeylogfile error handling logging
- a6c0bf93031d 19 (unreleased) landed
- 39f01083facd 18.0 landed
-
Mark sslkeylogfile as Debug option
- 2970c75dd982 18.0 landed
-
libpq: Add support for dumping SSL key material to file
- 2da74d8d6400 18.0 landed