Horton

Re: Improve a few appendStringInfo calls new to v18

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-11T13:45:18Z
Lists: pgsql-hackers 
Peter Eisentraut <peter@eisentraut.org> writes:
> Would it be useful to augment appendStringInfo() something like this:

> if (VA_ARGS_NARGS() == 0)
>      return appendStringInfoString(str, fmt);

That would change the behavior in edge cases, for instance
appendStringInfo(str, "foo%%bar").  Maybe we'd never hit those,
but on the whole I'm not in love with the idea.

			regards, tom lane

Commits

  1. Improve various new-to-v18 appendStringInfo calls

  2. Fixup various StringInfo function usages