Re: Consistently use palloc_object() and palloc_array()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: David Geier <geidav.pg@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, Thomas Munro <thomas.munro@gmail.com>, Chao Li <li.evan.chao@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2025-12-11T15:32:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

btree_gist: Fix memory allocation formula
- 5cf03552fbb4 19 (unreleased) landed
Use palloc_object() and palloc_array(), the last change
- 4f7dacc5b82a 19 (unreleased) landed
pg_buffercache: Fix memory allocation formula
- 580b5c2f397f 18.2 landed
- 3f83de20ba2e 19 (unreleased) landed
Fix allocation formula in llvmjit_expr.c
- 0c67dbcc4e39 14.21 landed
- 07ddf6197b78 15.16 landed
- 5a4dc4aabd03 16.12 landed
- 0bab0c3b74af 17.8 landed
- 5b7bbf16db34 18.2 landed
- 06761b6096b6 19 (unreleased) landed
Use palloc_object() and palloc_array() in backend code
- 1b105f9472bd 19 (unreleased) landed
Use palloc_object() and palloc_array() in more areas of the tree
- 0c3c5c3b06a3 19 (unreleased) landed
Use more palloc_object() and palloc_array() in contrib/
- 31d3847a37be 19 (unreleased) landed

David Geier <geidav.pg@gmail.com> writes:
> Do we know what code each build animal actually has enabled?

Of course.  The configuration is reported in the logs of every
buildfarm run.  For instance, in the most recent run at this
moment,

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=caiman&dt=2025-12-11%2015%3A00%3A05

we can see

  $ ./configure --enable-cassert --enable-debug --enable-nls --with-perl \
        --with-python --with-tcl --with-gssapi --with-openssl --with-ldap \
        --with-libxml --with-libxslt --with-pam --with-selinux \
        --with-systemd --with-liburing --with-libcurl --with-libnuma \
        --with-lz4 --with-zstd --prefix=/repos/client-code-REL_20/HEAD/inst \
        --with-pgport=5678 --cache-file=/repos/client-code-REL_20/accache-caiman/config-HEAD.cache

and you can drill down to the "configure" step if you want more
detail.

> Do build animal owners try to enable as much code as possible, or is
> this completely up to what the owner happened to do when setting up the
> build animal?

It's the owner's choice.  The buildfarm client's sample config file
has a list of suggested options, and I wouldn't be too surprised
if a lot of people just left that list alone.  I think the ones
paying closer attention probably try to enable as much as they can.

			regards, tom lane