Re: row literal problem
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Merlin Moncure <mmoncure@gmail.com>, Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-07-20T06:31:33Z
Lists: pgsql-hackers
Attachments
- whole-row-junk-cols.patch (text/x-patch) patch
I wrote: > I think the way to solve this is to do whatever it takes to get access > to the subplan targetlist. We could then do something a bit cleaner > than what the named-rowtype code is currently doing: if there are > resjunk columns in the subplan targetlist, use the tlist to create a > JunkFilter, and then pass the tuples through that. After that we can > insist that the tuples don't have any extra columns. Here's a draft patch for that. It wasn't quite as ugly as I feared. A lot of the apparent bulk of the patch is because I chose to split ExecEvalVar into separate functions for the scalar and whole-row cases, which seemed appropriate because they now get different ExprState node types. regards, tom lane