Re: pageinspect: Hash index support

Jesper Pedersen <jesper.pedersen@redhat.com>

From: Jesper Pedersen <jesper.pedersen@redhat.com>

To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

Cc: Michael Paquier <michael.paquier@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, Jeff Janes <jeff.janes@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2016-09-27T14:10:42Z

Lists: pgsql-hackers

Attachments

0001-pageinspect-Hash-index-support_v7.patch (text/x-patch)

On 09/26/2016 10:45 PM, Peter Eisentraut wrote:
> On 9/26/16 1:39 PM, Jesper Pedersen wrote:
>> Left as is, since BuildTupleFromCStrings() vs. xyzGetDatum() are equally
>> readable in this case. But, I can change the patch if needed.
>
> The point is that to use BuildTupleFromCStrings() you need to convert
> numbers to strings, and then they are converted back.  This is not a
> typical way to write row-returning functions.
>

Ok.

Changed:
  * BuildTupleFromCStrings -> xyzGetDatum
  * 'type' field: char -> text w/ full description
  * Removed 'type' information from documentation

Best regards,
  Jesper

Commits

Fix incorrect typecast.
- b4316928d57b 10.0 landed
In pageinspect/hashfuncs.c, avoid crashes on alignment-picky machines.
- 14e9b18fed28 10.0 landed
pageinspect: Support hash indexes.
- 08bf6e529587 10.0 landed
Add uuid to the set of types supported by contrib/btree_gist.
- 11da83a0e70d 10.0 cited
Allow CREATE EXTENSION to follow extension update paths.
- 40b449ae84dc 10.0 cited