Re: Split copy.c

Erik Rijkers <er@xs4all.nl>

From: Erikjan Rijkers <er@xs4all.nl>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: David Rowley <dgrowleyml@gmail.com>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>
Date: 2020-11-03T08:46:36Z
Lists: pgsql-hackers
On 2020-11-03 08:38, Heikki Linnakangas wrote:

> [v3-0001-Split-copy.c-into-copyto.c-and-copyfrom.c.patch]
> [v3-0002-Split-copyfrom.c-further-into-copyfrom.c-and-copy.patch]

The patches apply ok, but I get these errors:

In file included from ../../../src/include/postgres.h:46,
                  from copyto.c:15:
copyto.c: In function ‘BeginCopyTo’:
copyto.c:477:11: error: ‘is_from’ undeclared (first use in this 
function); did you mean ‘is_program’?
    Assert(!is_from);
            ^~~~~~~
../../../src/include/c.h:790:9: note: in definition of macro ‘Assert’
    if (!(condition)) \
          ^~~~~~~~~
copyto.c:477:11: note: each undeclared identifier is reported only once 
for each function it appears in
    Assert(!is_from);
            ^~~~~~~
../../../src/include/c.h:790:9: note: in definition of macro ‘Assert’
    if (!(condition)) \
          ^~~~~~~~~



Commits

  1. Split copy.c into four files.