Re: Keywords in pg_hba.conf should be field-specific
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Brendan Jurd <direvus@gmail.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Fujii Masao <masao.fujii@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-10-17T14:19:10Z
Lists: pgsql-hackers
Brendan Jurd <direvus@gmail.com> writes: > On 17 October 2010 09:59, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Good point. Maybe the correct fix is to remember whether each token was >> quoted or not, so that keyword detection can be done safely after the >> initial lexing. I still think that the current method is impossibly >> ugly ... > I'm happy to revise the patch on that basis. Any suggestions about > how to communicate the 'quotedness' of each token? We could make each > token a struct consisting of the token itself, plus a boolean flag to > indicate whether it had been quoted. Does that work for you? Seems reasonable. I had the idea of a parallel list of booleans in the back of my mind, but a list of structs is probably easier to understand, and to extend further if necessary. regards, tom lane