Horton

Re: Getting rid of "unknown error" in dblink and postgres_fdw

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgresql.org
Date: 2016-12-22T14:55:55Z
Lists: pgsql-hackers 
Joe Conway <mail@joeconway.com> writes:
> On 12/21/2016 09:20 PM, Tom Lane wrote:
>> I see that you need to pass the PGconn into dblink_res_error() now, but
>> what's the point of the new "bool fail" parameter?

> That part isn't new -- we added it sometime prior to 9.2:

Oh!  I misread the patch --- something about an unluckily-placed line
wrap and not looking very closely :-(.  Yeah, it's fine as is.
Sorry for the noise.

			regards, tom lane

Commits

  1. Make dblink try harder to form useful error messages

  2. Improve dblink error message when remote does not provide it