Horton

Re: Rearranging ALTER TABLE to avoid multi-operations bugs

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-15T16:32:38Z
Lists: pgsql-hackers 
Sergei Kornilov <sk@zsrv.org> writes:
> I am clearly not a good reviewer for such changes... But for a note: I read the v4 patch and have no useful comments. Good new tests, reasonable code changes to fix multiple bug reports.

Thanks for looking!

> The patch is proposed only for the master branch, right?

Yes, it seems far too risky for the back branches.

			regards, tom lane

Commits

  1. Clarify behavior of adding and altering a column in same ALTER command.

  2. Restructure ALTER TABLE execution to fix assorted bugs.

  3. doc: Add best practises section to partitioning docs

  4. Allow on-the-fly capture of DDL event details