Horton

Re: [PATCH] Fix incorrect fprintf usage in log_error FRONTEND path

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bryan Green <dbryan.green@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2025-10-13T21:59:37Z
Lists: pgsql-hackers 
Bryan Green <dbryan.green@gmail.com> writes:
> The problem:
> - FRONTEND path: fprintf(stderr, fmt, ap) - incorrect
> - non-FRONTEND path: write_stderr(fmt, ap) - also incorrect

> The first patch only addressed the fprintf issue.  The v2 patch 
> addresses both.

Actually, you'd managed to drop the fprintf->vfprintf change :-(.
I fixed that, pgindent'd it, wordsmithed the commit message,
and pushed.  Many thanks for finding this!

			regards, tom lane

Commits

  1. Fix incorrect message-printing in win32security.c.