Re: pgindent vs. pgperltidy command-line arguments

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-06T15:47:33Z
Lists: pgsql-hackers

Attachments

On 2023-06-21 We 07:35, Andrew Dunstan wrote:
>
>
> On 2023-06-21 We 05:09, Peter Eisentraut wrote:
>> On 20.06.23 17:38, Andrew Dunstan wrote:
>>>>> +1, although I wonder if we shouldn't follow pgindent's new lead
>>>>> and require some argument(s).
>>>>
>>>> That makes sense to me.  Here is a small update with this behavior 
>>>> change and associated documentation update.
>>>
>>> I'm intending to add some of the new pgindent features to 
>>> pgperltidy. Preparatory to that here's a rewrite of pgperltidy in 
>>> perl - no new features yet but it does remove the hardcoded path, 
>>> and requires you to pass in one or more files / directories as 
>>> arguments.
>>
>> Are you planning to touch pgperlcritic and pgperlsyncheck as well? 
>
>
> Yeah, it would make sense to.
>


Here's a patch that turns all these into perl scripts.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

  1. Allow and require passing files on command line of pgperltidy