Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Heikki Linnakangas <hlinnakangas@vmware.com>, pgsql-hackers@postgresql.org
Date: 2013-01-13T21:16:10Z
Lists: pgsql-hackers
Andres Freund <andres@2ndquadrant.com> writes:
>> Basically, the aspects of this that I think are likely to be
>> reproducible wins across different platforms are (a) teaching the
>> compiler that elog(ERROR) doesn't return, and (b) reducing code size as
>> much as possible.  The single-function change isn't going to help on
>> either ground --- maybe it would have helped on (b) without the errno
>> problem, but that's going to destroy any possible code size savings.

> Agreed. I am happy to produce an updated patch unless youre already on
> it?

On it now (busy testing on some old slow boxes, else I'd be done already).

			regards, tom lane


Commits

  1. Prevent creation of postmaster's TCP socket during pg_upgrade testing.