Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows

Florents Tselai <florents.tselai@gmail.com>

From: Florents Tselai <florents.tselai@gmail.com>
To: Andrew Kane <andrew@ankane.org>
Cc: pgsql-hackers@postgresql.org
Date: 2024-09-13T21:27:47Z
Lists: pgsql-hackers

> On 13 Sep 2024, at 11:07 PM, Andrew Kane <andrew@ankane.org> wrote:
> 
> Hi,
> 
> With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and `float_to_shortest_decimal_bufn` are not longer exported. This causes `unresolved external symbol` linking errors for extensions that rely on these functions (like pgvector). Can these functions be exported like previous versions of Postgres?

Probably a Windows thing?
Just tried on Darwin with 17_RC1, and pgvector 0.7.4 build installcheck’s OK. 


> 
> Thanks,
> Andrew




Commits

  1. meson: Export all libcommon functions in Windows builds