Re: Minimal logical decoding on standbys

Jonathan S. Katz <jkatz@postgresql.org>

From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Andres Freund <andres@anarazel.de>, "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Jeff Davis <pgsql@j-davis.com>, Robert Haas <robertmhaas@gmail.com>, Thomas Munro <thomas.munro@gmail.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, Amit Khandekar <amitdkhan.pg@gmail.com>, fabriziomello@gmail.com, tushar <tushar.ahuja@enterprisedb.com>, Rahila Syed <rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-04-08T17:12:16Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Reduce the log level in 035_standby_logical_decoding.pl.

  2. 035_standby_logical_decoding: Add missing waits for replication

  3. For cascading replication, wake physical and logical walsenders separately

  4. Handle logical slot conflicts on standby

  5. Support invalidating replication slots due to horizon and wal_level

  6. Prevent use of invalidated logical slot in CreateDecodingContext()

  7. Replace replication slot's invalidated_at LSN with an enum

  8. Pass down table relation into more index relation functions

  9. Assert only valid flag bits are passed to visibilitymap_set()

  10. Remove unused _bt_delitems_delete() argument.

  11. Add xl_btree_delete optimization.

On 4/8/23 5:27 AM, Andres Freund wrote:
> Hi,
> 
> On 2023-04-07 14:27:09 -0700, Andres Freund wrote:
>> I think I'll push these in a few hours. While this needed more changes than
>> I'd like shortly before the freeze, I think they're largely not in very
>> interesting bits and pieces - and this feature has been in the works for about
>> three eternities, and it is blocking a bunch of highly requested features.
>>
>> If anybody still has energy, I would appreciate a look at 0001, 0002, the new
>> pieces I added, to make what's now 0003 and 0004 cleaner.
> 
> Pushed. Thanks all!
> 
> I squashed some of the changes. There didn't seem to be a need for a separate
> stats commit, or a separate docs commit. Besides that, I did find plenty of
> grammar issues, and a bunch of formatting issues.
> 
> Let's see what the buildfarm says.

Thanks to everyone for working on this feature -- this should have a big 
impact on users of logical replication!

While it still needs to get through the beta period etc. this is a big 
milestone for what's been a multi-year effort to support this.

Thanks,

Jonathan