Horton

Re: Remove custom redundant full page write description from GIN

Andrey Borodin <x4mmm@yandex-team.ru>

View thread
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-10T18:59:52Z
Lists: pgsql-hackers 

> On 9 Oct 2025, at 17:33, Kirill Reshke <reshkekirill@gmail.com> wrote:
> 
> Should we remove them, reducing overall cognitive complexity of GIN
> internals and reducing WAL footprint?

The patch does not add a single line... that's impressive :)

Why not wipe ginxlogSplit entirely? Will the code be clearer with XLogRegisterData(&flags, sizeof(uint16))?


Best regards, Andrey Borodin.