Re: SerializeParamList vs machines with strict alignment
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
hlinnaka <hlinnaka@iki.fi>
Date: 2018-10-02T01:38:53Z
Lists: pgsql-hackers
Amit Kapila <amit.kapila16@gmail.com> writes: > I think if we do Analyze on the table after populating rows, it should > use just one worker and that should be sufficient to hit the case > being discussed. I would like to change the test so that it uses just > one worker. I thought that adding an ANALYZE would make the test be net slower, not faster; ANALYZE isn't free, even on just a row or so. Also, I believe that coding the test this way makes the leader send the param values to multiple workers, which would flush out any problems with serializing a value multiple times. As against that, there's a hazard that the number of workers might not be stable ... but it seems like we have lots of other occurrences of that same hazard elsewhere in this test script. regards, tom lane
Commits
-
MAXALIGN the target address where we store flattened value.
- dca44d07c585 9.6.11 landed
- 9718c93f532c 10.6 landed
- 9bc9f72b28fe 12.0 landed
- ca5ca25d0871 11.0 landed
-
Test passing expanded-value representations to workers.
- 0fd6a8a7d0ce 12.0 landed