Re: myProcLocks initialization
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-10-31T20:22:45Z
Lists: pgsql-hackers
Simon Riggs <simon@2ndQuadrant.com> writes: > On Mon, Oct 31, 2011 at 7:54 PM, Robert Haas <robertmhaas@gmail.com> wrote: >> Revised patch attached. I think it would be useful to assert this >> both at process startup time and at process shutdown, since it would >> really be much nicer to have the process that didn't clean up fail the >> assertion, rather than the new one that innocently inherited its slot; >> so the attached patch takes that approach. > Something stronger than an assertion at shutdown? Run-time test? There's currently no evidence to suggest this will ever fire at all, especially not in non-development builds, so an assert seems enough to me. regards, tom lane