Horton

Re: [BUG] pg_upgrade test fails from older versions.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Anton A. Melnikov" <aamelnikov@inbox.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-12-19T01:56:48Z
Lists: pgsql-hackers 
"Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
> 2) In 60684dd83 and b5d63824 there are two changes in the set of specific privileges.
> The thing is that in the privileges.sql test there is REVOKE DELETE command
> which becomes pair of REVOKE ALL and GRANT all specific privileges except DELETE
> in the result dump. Therefore, any change in the set of specific privileges will lead to
> a non-zero dumps diff.
> To avoid this, i propose to replace any specific GRANT and REVOKE in the result dumps with ALL.
> This also made in the patch attached.

Isn't that likely to mask actual bugs?

			regards, tom lane

Commits

  1. Add custom filtering rules to the TAP tests of pg_upgrade

  2. Switch query fixing aclitems in ~15 from O(N^2) to O(N) in upgrade_adapt.sql

  3. Update upgrade_adapt.sql to handle tables using aclitem as data type

  4. Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS