Re: Change JOIN tutorial to focus more on explicit joins

David Steele <david@pgmasters.net>

From: David Steele <david@pgmasters.net>

To: Jürgen Purtz <juergen@purtz.de>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "David G. Johnston" <david.g.johnston@gmail.com>

Date: 2021-03-10T13:06:16Z

Lists: pgsql-hackers, pgsql-docs

On 12/1/20 3:38 AM, Jürgen Purtz wrote:
> On 30.11.20 21:25, David G. Johnston wrote:
>> Sorry, I managed to overlook the most recent patch.
>>
>> I admitted my use of parentheses was incorrect and I don't see anyone 
>> else defending them.  Please remove them.
>>
>> Minor typos:
>>
>> "the database compare" -> needs an "s" (compares)
>>
>> "In this case, the definition how to compare their rows." -> remove, 
>> redundant with the first sentence
>>
>> "The results from the older implicit syntax, and the newer explicit 
>> JOIN/ON syntax, are identical" -> move the commas around to what is 
>> shown here
>>
>>
> OK. Patch attached.

Peter, you committed some of this patch originally. Do you think the 
rest of the patch is now in shape to be committed?

Regards,
-- 
-David
david@pgmasters.net

Commits

doc: Prefer explicit JOIN syntax over old implicit syntax in tutorial
- fb310f17812e 14.0 landed
doc: Change table alias names to lower case in tutorial chapter
- 49d716511789 14.0 landed
doc: Fix whitespace issue in PDF
- 79fd620b20b7 14.0 landed
doc: Use tags consistently in the tutorial chapter
- 6eee73e4e5b6 14.0 landed