Horton

Thread

Commits

  1. Update some incorrect comments about xlog records.

  1. Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2023-01-06T10:05:07Z

    Hi hackers,

Please find attached a patch to $SUBJECT.

The wrong comments have been discovered by Robert in [1].

Submitting this here as a separate thread so it does not get lost in the logical decoding
on standby thread.

[1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com

Looking forward to your feedback,

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  2. Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2023-03-02T13:04:58Z

    Hi,

On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
> Hi hackers,
> 
> Please find attached a patch to $SUBJECT.
> 
> The wrong comments have been discovered by Robert in [1].
> 
> Submitting this here as a separate thread so it does not get lost in the logical decoding
> on standby thread.
> 
> [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
> 
> Looking forward to your feedback,
> 
> Regards,
> 

It looks like I did not create a CF entry for this one: fixed with [1].

Also, while at it, adding a commit message in V2 attached.

[1]: https://commitfest.postgresql.org/43/4235/

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  3. Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Amit Kapila <amit.kapila16@gmail.com> — 2023-03-03T11:30:59Z

    On Thu, Mar 2, 2023 at 6:35 PM Drouvot, Bertrand
<bertranddrouvot.pg@gmail.com> wrote:
>
> On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
> > Hi hackers,
> >
> > Please find attached a patch to $SUBJECT.
> >
> > The wrong comments have been discovered by Robert in [1].
> >
> > Submitting this here as a separate thread so it does not get lost in the logical decoding
> > on standby thread.
> >
> > [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
> >
> > Looking forward to your feedback,
> >
> > Regards,
> >
>
> It looks like I did not create a CF entry for this one: fixed with [1].
>
> Also, while at it, adding a commit message in V2 attached.
>

LGTM.

-- 
With Regards,
Amit Kapila.

  4. Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2023-03-03T16:28:47Z

    Hi,

On 3/3/23 12:30 PM, Amit Kapila wrote:
> On Thu, Mar 2, 2023 at 6:35 PM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>>
>> On 1/6/23 11:05 AM, Drouvot, Bertrand wrote:
>>> Hi hackers,
>>>
>>> Please find attached a patch to $SUBJECT.
>>>
>>> The wrong comments have been discovered by Robert in [1].
>>>
>>> Submitting this here as a separate thread so it does not get lost in the logical decoding
>>> on standby thread.
>>>
>>> [1]: https://www.postgresql.org/message-id/CA%2BTgmoYTTsxP8y6uknZvCBNCRq%2B1FJ4zGbX8Px1TGW459fGsaQ%40mail.gmail.com
>>>
>>> Looking forward to your feedback,
>>>
>>> Regards,
>>>
>>
>> It looks like I did not create a CF entry for this one: fixed with [1].
>>
>> Also, while at it, adding a commit message in V2 attached.
>>
> 
> LGTM.
> 

Thanks for having looked at it!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  5. Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Robert Haas <robertmhaas@gmail.com> — 2023-03-03T17:53:10Z

    On Fri, Mar 3, 2023 at 11:28 AM Drouvot, Bertrand
<bertranddrouvot.pg@gmail.com> wrote:
> Thanks for having looked at it!

+1. Committed.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  6. Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Bertrand Drouvot <bertranddrouvot.pg@gmail.com> — 2023-03-04T08:33:45Z

    Hi,

On 3/3/23 6:53 PM, Robert Haas wrote:
> On Fri, Mar 3, 2023 at 11:28 AM Drouvot, Bertrand
> <bertranddrouvot.pg@gmail.com> wrote:
>> Thanks for having looked at it!
> 
> +1. Committed.
> 

Thanks!

Not a big deal, but the commit message that has been used is not 100% accurate.

Indeed, for gistxlogDelete, that's the other way around (as
compare to what the commit message says).

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

  7. Re: Fix comments in gistxlogDelete, xl_heap_freeze_page and xl_btree_delete

    Robert Haas <robertmhaas@gmail.com> — 2023-03-06T15:08:16Z

    On Sat, Mar 4, 2023 at 3:33 AM Drouvot, Bertrand
<bertranddrouvot.pg@gmail.com> wrote:
> Indeed, for gistxlogDelete, that's the other way around (as
> compare to what the commit message says).

Woops. Good point.

-- 
Robert Haas
EDB: http://www.enterprisedb.com