Horton

Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: d.kovalenko@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Date: 2025-09-03T14:48:17Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make libpq_pipeline.c shorter and more uniform via helper functions.

  2. pg_dump: Allow pg_dump to dump the statistics for foreign tables.

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Jun-21, Tom Lane wrote:
>> Here's a shot at improving matters.  I also made an effort
>> at cleaning up memory leaks in libpq_pipeline.c, although
>> that's surely neatnik-ism not anything meaningful.

> Yeah, the code looks much better this way.  I thought it was a bit odd
> that a function called confirm_result_status() would actually consume
> said status.  Would it be better as
>   consume_result_status(PGconn *conn, ExecStatusType expected)
> ?

Hm, I chose that name by analogy to the adjacent
confirm_query_canceled(), which is likewise consuming a result.
I agree that "consume" is a better verb, but then let's rename
confirm_query_canceled as well.

> I think the patch is a clear improvement regardless.

Thanks for reviewing!

			regards, tom lane