Re: [COMMITTERS] pgsql: Add function to import operating system collations
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Date: 2017-01-21T20:17:26Z
Lists: pgsql-hackers
On 1/21/17 12:50 PM, Tom Lane wrote: > I have to question the decision to make "no locales" a hard error. > What's the point of that? In fact, should we even be bothering with > a warning, considering how often initdb runs unattended these days? Hmm, it was a warning in initdb, so making it an error now is probably a mistake. We should change it back to a warning at least. The reason for the warning originally was to have some output in case the whole collation initialization fails altogether and does nothing. For example, at the time, we didn't know how reliable and portable `locale -a` actually was. Maybe this didn't actually turn out to be a problem. Also, if we add ICU initialization to this, then it's not clear how we would report if one provider provided zero locales but another did provide some. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Avoid conflicts with collation aliases generated by stripping.
- 0333a7340054 10.0 landed
-
Add function to import operating system collations
- aa17c06fb585 10.0 cited
-
Remove dead code in bootstrap
- 193a7d791ebe 10.0 cited