Horton

Re: Preserve attstattarget on REINDEX CONCURRENTLY

Ronan Dunklau <ronan@dunklau.fr>

View thread View on postgr.es
From: Ronan Dunklau <ronan@dunklau.fr>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Date: 2021-02-04T14:52:44Z
Lists: pgsql-hackers

Attachments

> 
> Hmmm, that sure seems like a bug, or at least unexpected behavior (that
> I don't see mentioned in the docs).
> 
> But the patch seems borked in some way:
> 
> $ patch -p1 < ~/keep_attstattargets_on_reindex_concurrently.patch
> patch: **** Only garbage was found in the patch input.
> 
> There seem to be strange escape characters and so on, how did you 
> create
> the patch? Maybe some syntax coloring, or something?

You're right, I had syntax coloring in the output, sorry.

Please find attached a correct patch.

Regards,

--
Ronan Dunklau

Commits

  1. Fix ORDER BY clause in new regression test of REINDEX CONCURRENTLY

  2. Preserve pg_attribute.attstattarget across REINDEX CONCURRENTLY