Re: crash in pg_identify_object_as_address

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-18T22:13:27Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I just came across a crash while debugging some corrupted system
> catalogs; pg_identify_object_as_address fails to cope with some NULL
> input, causing a crash.  Attached patch fixes it.  Naturally, the output
> array will contain NULL members in the output, but that's better than
> crashing ...

Hm, does this overlap with Paquier's much-delayed patch in
https://commitfest.postgresql.org/22/1947/
?

			regards, tom lane


Commits

  1. Make object address handling more robust