Horton

Thread

Commits

  1. Improve description of pg_attrdef in documentation

  1. Change pg_attribute textual link to an actual link

    Daniel Gustafsson <daniel@yesql.se> — 2018-10-21T20:29:58Z

    In the System catalog/pg_attrdef documentation, there is a reference to
pg_attribute with the text “see below”.  That makes sense in the PDF version
(and similar renderings), but in the web version it seems a bit odd as
pg_attribute is on the next page, not below.

The attached patch changes it to an actual link instead, but simply removing
the “see below” bit is another approach which isn’t out of line with other
parts of the documentation (I opted for link since I personally prefer that).

cheers ./daniel

  2. Re: Change pg_attribute textual link to an actual link

    Tom Lane <tgl@sss.pgh.pa.us> — 2018-10-21T23:27:21Z

    Daniel Gustafsson <daniel@yesql.se> writes:
> In the System catalog/pg_attrdef documentation, there is a reference to
> pg_attribute with the text "see below".  That makes sense in the PDF version
> (and similar renderings), but in the web version it seems a bit odd as
> pg_attribute is on the next page, not below.

> The attached patch changes it to an actual link instead, but simply removing
> the "see below" bit is another approach which isn't out of line with other
> parts of the documentation (I opted for link since I personally prefer that).

I agree with your change, but I wonder if the sentence after this one
doesn't need some work too.  It seems to predate ALTER COLUMN SET DEFAULT.
We could add a mention of that, or just stop trying to describe the
preconditions, and say something like "only columns for which a default
value has been explicitly set will have an entry here".

			regards, tom lane

  3. Re: Change pg_attribute textual link to an actual link

    Daniel Gustafsson <daniel@yesql.se> — 2018-10-22T10:09:41Z

    > On 22 Oct 2018, at 01:27, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> In the System catalog/pg_attrdef documentation, there is a reference to
>> pg_attribute with the text "see below".  That makes sense in the PDF version
>> (and similar renderings), but in the web version it seems a bit odd as
>> pg_attribute is on the next page, not below.
> 
>> The attached patch changes it to an actual link instead, but simply removing
>> the "see below" bit is another approach which isn't out of line with other
>> parts of the documentation (I opted for link since I personally prefer that).
> 
> I agree with your change, but I wonder if the sentence after this one
> doesn't need some work too.  It seems to predate ALTER COLUMN SET DEFAULT.
> We could add a mention of that, or just stop trying to describe the
> preconditions, and say something like "only columns for which a default
> value has been explicitly set will have an entry here”.

I think your latter suggestion pretty much covers all we need, so updated the
patch with that too.

cheers ./daniel

  4. Re: Change pg_attribute textual link to an actual link

    Michael Paquier <michael@paquier.xyz> — 2018-10-29T07:39:54Z

    On Mon, Oct 22, 2018 at 12:09:41PM +0200, Daniel Gustafsson wrote:
> I think your latter suggestion pretty much covers all we need, so updated the
> patch with that too.

Both the patch and the suggestions made look good to me, so committed.
--
Michael

  5. Re: Change pg_attribute textual link to an actual link

    Daniel Gustafsson <daniel@yesql.se> — 2018-10-29T10:00:43Z

    > On 29 Oct 2018, at 08:39, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Mon, Oct 22, 2018 at 12:09:41PM +0200, Daniel Gustafsson wrote:
>> I think your latter suggestion pretty much covers all we need, so updated the
>> patch with that too.
> 
> Both the patch and the suggestions made look good to me, so committed.

Thanks! I updated the status in the CF app to Committed.

cheers ./daniel