Horton

Re: pgbench bug candidate: negative "initial connection time"

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, kuroda.hayato@fujitsu.com, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-02T14:11:39Z
Lists: pgsql-hackers 

On 2021/11/01 23:01, Fujii Masao wrote:
>> The remainings are the changes of handling of initial connection or
>> logfile open failures. I agree to push them at least for the master.
>> But I'm not sure if they should be back-patched. Without these changes,
>> even when those failures happen, pgbench proceeds the benchmark and
>> reports the result. But with the changes, pgbench exits immediately in
>> that case. I'm not sure if there are people who expect this behavior,
>> but if there are, maybe we should not change it at least at stable branches.
>> Thought?
> 
> The current behavior should be improved, but not a bug.
> So I don't think that the patch needs to be back-patched.
> Barring any objection, I will push the attached patch to the master.

Pushed. Thanks!

I also pushed the typo-fix patch that I proposed upthread.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. pgbench: Fix typo in comment.

  2. pgbench: Improve error-handling in pgbench.

  3. pgbench: Fix handling of socket errors during benchmark.

  4. pgbench: Correct log level of message output when socket wait method fails.

  5. pgbench: Synchronize client threads.

  6. pgbench: Use common logging API