Horton

Retiring support for pre-7.3 FK constraint triggers

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-03-05T13:38:30Z
Lists: pgsql-hackers

Attachments

While looking at the tg_updatedcols patch I happened to notice that we still
support pre-7.3 constraint triggers by converting them on the fly.  AFAICT this
requires a pre-7.3 dump to hit.

This was added in late 2007 in a2899ebdc28080eab0f4bb0b8a5f30aa7bb31a89 due to
a report from the field, but I doubt this codepath is excercised much today (if
at all).

Having code which is untested and not excercised by developers (or users, if my
assumption holds), yet being reachable by SQL, runs the risk of introducing
subtle bugs.  Is there a usecase for keeping it, or can/should it be removed in
14?  That would still leave a lot of supported versions to upgrade to in case
there are users to need this.  Unless there are immediate -1's, I'll park this
in a CF for v14.

cheers ./daniel

Commits

  1. Remove ancient hacks to ignore certain opclass names in CREATE INDEX.

  2. Remove ancient support for upgrading pre-7.3 foreign key constraints.

  3. Support for INCLUDE attributes in GiST indexes

  4. Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers.

  5. Teach CREATE CONSTRAINT TRIGGER to convert old-style foreign key